Only fetch @remote_coverage_tools when collecting coverage #16995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stacked on #16994, which should be merged first. |
fmeum
force-pushed
the
15088-cc-test-optional-coverage
branch
from
841bd5e
to
986246f
Compare
|
@c-mita Could you review? |
|
@bazel-io flag (flagging for 6.1.0, not a regression) |
bazel-io
added
the
potential release blocker
fmeum
force-pushed
the
15088-cc-test-optional-coverage
branch
2 times, most recently
from
0f7a97e
to
78a53bf
Compare
|
cc @metti |
fmeum
force-pushed
the
15088-cc-test-optional-coverage
branch
from
78a53bf
to
7b6d7f5
Compare
|
No longer stacked. |
sgowroji
added
team-Rules-CPP
Before this change, every test rule had an implicit dependency on `@bazel_tools//tools/test:coverage_report_generator`, even though this tool is only used when collecting coverage. This is fixed by moving it to `CoverageOptions` and using the late-bound default resolver to only create a dependency if coverage is enabled. Also adds `CoverageOptions` to the set of options classes trimmed by `--trim_test_configuration` so that, as before, changing `--coverage_report_generator` doesn't cause non-test rules to be reanalyzed. This behavior now extends to `--coverage_output_generator`.
fmeum
force-pushed
the
15088-cc-test-optional-coverage
branch
from
7b6d7f5
to
aec5d92
Compare
|
@coeuvre The BwoB integration test has been relatively flaky on Windows: https://storage.googleapis.com/bazel-untrusted-buildkite-artifacts/01850aa0-b0ed-4f39-bc17-c104624005a5/src%5Ctest%5Cjava%5Ccom%5Cgoogle%5Cdevtools%5Cbuild%5Clib%5Cremote%5CBuildWithoutTheBytesIntegrationTest%5Cshard_4_of_5%5Ctest.log |
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
comius
approved these changes
Dec 27, 2022
comius
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
Before this change, every test rule had an implicit dependency on `@bazel_tools//tools/test:coverage_report_generator`, even though this tool is only used when collecting coverage. This is fixed by moving it to `CoverageOptions` and using the late-bound default resolver to only create a dependency if coverage is enabled. Also adds `CoverageOptions` to the set of options classes trimmed by `--trim_test_configuration` so that, as before, changing `--coverage_report_generator` doesn't cause non-test rules to be reanalyzed. This behavior now extends to `--coverage_output_generator`. Fixes #15088 Closes #16995. PiperOrigin-RevId: 498949871 Change-Id: I2440fae2655bbb701e918ee2aa7acb008d8f97ed
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Feb 16, 2023
Before this change, every test rule had an implicit dependency on `@bazel_tools//tools/test:coverage_report_generator`, even though this tool is only used when collecting coverage. This is fixed by moving it to `CoverageOptions` and using the late-bound default resolver to only create a dependency if coverage is enabled. Also adds `CoverageOptions` to the set of options classes trimmed by `--trim_test_configuration` so that, as before, changing `--coverage_report_generator` doesn't cause non-test rules to be reanalyzed. This behavior now extends to `--coverage_output_generator`. Fixes bazelbuild#15088 Closes bazelbuild#16995. PiperOrigin-RevId: 498949871 Change-Id: I2440fae2655bbb701e918ee2aa7acb008d8f97ed
keertk
added a commit
that referenced
this pull request
Feb 19, 2023
Before this change, every test rule had an implicit dependency on `@bazel_tools//tools/test:coverage_report_generator`, even though this tool is only used when collecting coverage. This is fixed by moving it to `CoverageOptions` and using the late-bound default resolver to only create a dependency if coverage is enabled. Also adds `CoverageOptions` to the set of options classes trimmed by `--trim_test_configuration` so that, as before, changing `--coverage_report_generator` doesn't cause non-test rules to be reanalyzed. This behavior now extends to `--coverage_output_generator`. Fixes #15088 Closes #16995. PiperOrigin-RevId: 498949871 Change-Id: I2440fae2655bbb701e918ee2aa7acb008d8f97ed Co-authored-by: kshyanashree <[email protected]> Co-authored-by: keertk <[email protected]>
keertk
added a commit
that referenced
this pull request
Feb 19, 2023
…7287) * Only fetch @remote_coverage_tools when collecting coverage Before this change, every test rule had an implicit dependency on `@bazel_tools//tools/test:coverage_report_generator`, even though this tool is only used when collecting coverage. This is fixed by moving it to `CoverageOptions` and using the late-bound default resolver to only create a dependency if coverage is enabled. Also adds `CoverageOptions` to the set of options classes trimmed by `--trim_test_configuration` so that, as before, changing `--coverage_report_generator` doesn't cause non-test rules to be reanalyzed. This behavior now extends to `--coverage_output_generator`. Fixes #15088 Closes #16995. PiperOrigin-RevId: 498949871 Change-Id: I2440fae2655bbb701e918ee2aa7acb008d8f97ed * Update BUILD --------- Co-authored-by: Fabian Meumertzheim <[email protected]> Co-authored-by: keertk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, every test rule had an implicit dependency on
@bazel_tools//tools/test:coverage_report_generator, even though this tool is only used when collecting coverage.This is fixed by moving it to
CoverageOptionsand using the late-bound default resolver to only create a dependency if coverage is enabled.Also adds
CoverageOptionsto the set of options classes trimmed by--trim_test_configurationso that, as before, changing--coverage_report_generatordoesn't cause non-test rules to be reanalyzed. This behavior now extends to--coverage_output_generator.Fixes #15088